Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): don't provide directionality if user injector has one already #10004

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/cdk-experimental/dialog/dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,17 @@ export class Dialog {
const userInjector = config && config.viewContainerRef && config.viewContainerRef.injector;
const injectionTokens = new WeakMap();

injectionTokens.set(this.injector.get(DIALOG_REF), dialogRef);
injectionTokens.set(this.injector.get(DIALOG_CONTAINER), dialogContainer);
injectionTokens.set(DIALOG_DATA, config.data);
injectionTokens.set(Directionality, {
value: config.direction,
change: observableOf()
});
injectionTokens
.set(this.injector.get(DIALOG_REF), dialogRef)
.set(this.injector.get(DIALOG_CONTAINER), dialogContainer)
.set(DIALOG_DATA, config.data);

if (!userInjector || !userInjector.get(Directionality, null)) {
injectionTokens.set(Directionality, {
value: config.direction,
change: observableOf()
});
}

return new PortalInjector(userInjector || this.injector, injectionTokens);
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/chips/chip-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
*/
@Input()
get selectable(): boolean { return this._selectable; }
set selectable(value: boolean) {
set selectable(value: boolean) {
this._selectable = coerceBooleanProperty(value);
if (this.chips) {
this.chips.forEach(chip => chip.chipListSelectable = this._selectable);
Expand Down
20 changes: 12 additions & 8 deletions src/lib/dialog/dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,17 +269,21 @@ export class MatDialog {
const userInjector = config && config.viewContainerRef && config.viewContainerRef.injector;
const injectionTokens = new WeakMap();

injectionTokens.set(MatDialogRef, dialogRef);
// The MatDialogContainer is injected in the portal as the MatDialogContainer and the dialog's
// content are created out of the same ViewContainerRef and as such, are siblings for injector
// purposes. To allow the hierarchy that is expected, the MatDialogContainer is explicitly
// purposes. To allow the hierarchy that is expected, the MatDialogContainer is explicitly
// added to the injection tokens.
injectionTokens.set(MatDialogContainer, dialogContainer);
injectionTokens.set(MAT_DIALOG_DATA, config.data);
injectionTokens.set(Directionality, {
value: config.direction,
change: observableOf()
});
injectionTokens
.set(MatDialogContainer, dialogContainer)
.set(MAT_DIALOG_DATA, config.data)
.set(MatDialogRef, dialogRef);

if (!userInjector || !userInjector.get(Directionality, null)) {
injectionTokens.set(Directionality, {
value: config.direction,
change: observableOf()
});
}

return new PortalInjector(userInjector || this._injector, injectionTokens);
}
Expand Down