Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): hide overlay container when there are no attached overlays #10139

Merged
merged 1 commit into from
Feb 28, 2018
Merged

fix(overlay): hide overlay container when there are no attached overlays #10139

merged 1 commit into from
Feb 28, 2018

Conversation

crisbeto
Copy link
Member

Hides the .cdk-overlay-container if it doesn't have any attached overlays. This prevents the browser from rendering it as a transparent overlay.

Fixes #6882.
Fixes #10033.

@crisbeto
fix(overlay): hide overlay container when there are no attached overlays
55ba350 
Hides the `.cdk-overlay-container` if it doesn't have any attached overlays. This prevents the browser from rendering it as a transparent overlay.

Fixes angular#6882.
Fixes angular#10033.
@crisbeto crisbeto requested a review from jelbourn as a code owner February 25, 2018 12:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 25, 2018
jelbourn
jelbourn approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 26, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 26, 2018
@tinayuangao tinayuangao merged commit 4b528f6 into angular:master Feb 28, 2018
tinayuangao pushed a commit that referenced this pull request Mar 5, 2018
@crisbeto @tinayuangao
fix(overlay): hide overlay container when there are no attached overl…
d0bc91d 
…ays (#10139)

Hides the `.cdk-overlay-container` if it doesn't have any attached overlays. This prevents the browser from rendering it as a transparent overlay.

Fixes #6882.
Fixes #10033.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll smooth issue in dialog on close Performance issue: modals & popups
4 participants
@crisbeto @jelbourn @googlebot @tinayuangao