fix(tree): invalid style declaration during server-side rendering #10326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to camel-cased properties when declaring the inline styles for the tree, in order to avoid invalid style declarations when they get passed through Domino. Relates to angular#10131.
googlebot
added
the
cla: yes
|
@crisbeto just FYI, this has been patched in angular/angular#22263. Also I’m pretty sure it was the other way around, wasn’t it? (Ie the Renderer wouldn’t process camel case but would process dash-case) |
|
It was back-and-forth. With the older renderer it would process both, but it would literally set the camel-cased property as an inline style. The newer one seems to ignore dash-cased ones and it handles the camel-cased ones correctly. |
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to camel-cased properties when declaring the inline styles for the tree, in order to avoid invalid style declarations when they get passed through Domino.
Relates to #10131.