Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/icon): allow multiple classes in setDefaultFontSetClass #10484

Merged
merged 1 commit into from
Feb 28, 2022
Merged

feat(material/icon): allow multiple classes in setDefaultFontSetClass #10484

merged 1 commit into from
Feb 28, 2022

Conversation

crisbeto
Copy link
Member

Allows for the consumer to pass in multiple classes to MatIconRegistry.setDefaultFontSetClass.

Fixes #10471.

@crisbeto crisbeto requested a review from jelbourn as a code owner March 19, 2018 18:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 19, 2018
jelbourn
jelbourn approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Mar 29, 2018
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Apr 26, 2018
@crisbeto crisbeto force-pushed the 10471/icon-multiple-default-classes branch from fb1dda9 to d36d541 Compare July 16, 2018 20:54
@crisbeto crisbeto force-pushed the 10471/icon-multiple-default-classes branch from d36d541 to 2bcc9b2 Compare March 29, 2019 21:21
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
@crisbeto crisbeto force-pushed the 10471/icon-multiple-default-classes branch from 2bcc9b2 to cdb8286 Compare June 1, 2019 10:26
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@crisbeto crisbeto force-pushed the 10471/icon-multiple-default-classes branch from cdb8286 to 751e6f5 Compare February 26, 2022 07:46
@crisbeto crisbeto requested review from a team and andrewseguin as code owners February 26, 2022 07:46
@crisbeto crisbeto changed the title feat(icon): allow multiple classes in setDefaultFontSetClass feat(material/icon): allow multiple classes in setDefaultFontSetClass Feb 26, 2022
@crisbeto crisbeto force-pushed the 10471/icon-multiple-default-classes branch from 751e6f5 to de190fb Compare February 26, 2022 09:56
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Feb 26, 2022
@crisbeto crisbeto force-pushed the 10471/icon-multiple-default-classes branch 3 times, most recently from 47cef10 to e9138e0 Compare February 26, 2022 13:39
@crisbeto
feat(material/icon): allow multiple classes in setDefaultFontSetClass
5e9620e 
Allows for the consumer to pass in multiple classes to `MatIconRegistry.setDefaultFontSetClass`.

Fixes angular#10471.
@crisbeto crisbeto force-pushed the 10471/icon-multiple-default-classes branch from e9138e0 to 5e9620e Compare February 26, 2022 13:41
@crisbeto crisbeto removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Feb 28, 2022
@crisbeto crisbeto merged commit 6c7cc8a into angular:master Feb 28, 2022
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 14, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatIconRegistry request: allow registering multiple default font set classes
5 participants
@crisbeto @jelbourn @googlebot @mmalerba @andrewseguin