feat(material): use scoped injectables #10507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P1
jelbourn
requested review from
amcdnl,
andrewseguin,
devversion,
josephperrott,
kara and
tinayuangao
as code owners
googlebot
added
the
cla: yes
crisbeto
approved these changes
Mar 20, 2018
| import {CommonModule} from '@angular/common'; | ||
| import {NgModule} from '@angular/core'; | ||
| import {MatCommonModule, MatRippleModule} from '@angular/material/core'; | ||
| import {MatRadioButton, MatRadioGroup} from './radio'; | ||
|
|
||
|
|
||
| @NgModule({ | ||
| imports: [CommonModule, MatRippleModule, MatCommonModule, A11yModule], |
There was a problem hiding this comment.
Is removing this one intentional? The radio button has a dependency on the focus monitor from a11y.
There was a problem hiding this comment.
Removing here is okay since radio doesn't use any of the a11y directives. However, this comment made me realize I shouldn't have remove A11yModule from the date picker module. Fixed that.
jelbourn
force-pushed
the
mat-scoped-injectables
branch
from
2bc4db9 to
0ffe24a
Compare
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also catches cdk/layout which was missed earlier.
The overlay and the family of components based on it (dialog, snackbar, etc.) can't use the new semantics because they need the most appropriate
ComponentFactoryResolverinstead of the one that's always at the root.