fix(tab-group): focus change event not firing for keyboard navigation #12192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `focusChange` event only fires if the user *clicks* on a tab label. But if users navigate to the tabs using their keyboard and walk through the tab labels, the `focusChange` event is not firing properly. This also fixes that the scroll container, if pagination is active, does not update the scroll position smoothly. Fixes angular#12185
devversion
added
the
target: patch
googlebot
added
the
cla: yes
crisbeto
approved these changes
Jul 13, 2018
| // If there is a change in the focus key manager we need to emit the `indexFocused` | ||
| // event in order to provide a public event that notifies about focus changes. Also we realign | ||
| // the tabs container by scrolling the new focused tab into the visible section. | ||
| this._keyManager.change.pipe(takeUntil(this._destroyed)).subscribe(newFocusIndex => { |
There was a problem hiding this comment.
This will also fire for programmatic changes, but based on the old code, it seems like that's what we're expecting.
crisbeto
added
pr: lgtm
action: merge
This comment has been minimized.
This comment has been minimized.
josephperrott
pushed a commit
that referenced
this pull request
Jul 20, 2018
josephperrott
pushed a commit
that referenced
this pull request
Jul 20, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
focusChangeevent only fires if the user clicks on a tab label. But if users navigate to the tabs using their keyboard and walk through the tab labels, thefocusChangeevent is not firing properly.This also fixes that the scroll container, if pagination is active, does not update the scroll position smoothly.
Fixes #12185