Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): images in title-group overlapping content #12205

Merged

Conversation

devversion
Copy link
Member

  • Fixes that mat-card-$breakpoint-image images overlap the card content when placed inside of the title group.

@jelbourn Made it in a way that should be non-breaking for those using the xl-image outside of the mat-card-title-group. For those who use it inside of the title-group it can be considered a normal issue fix.

Fixes #10031

* Fixes that `mat-card-$breakpoint-image` images overlap the card content when placed inside of the title group.

Fixes angular#10031
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jul 14, 2018
@devversion devversion requested a review from jelbourn as a code owner July 14, 2018 10:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2018
@jelbourn
Copy link
Member

Would it be simpler to just make the xl image consistent with the rest?

@devversion
Copy link
Member Author

devversion commented Jul 17, 2018

I think it would be good to bring this change without breaking changes into the next patch release.

The extra CSS to avoid the breaking change is pretty small and can be removed and made consistent as soon as we make breaking changes.

For now the high priority is just to fix the images overlapping the content when used inside of a title group

(also xl is basically consistent within the the title group now)

@devversion
Copy link
Member Author

@jelbourn Please let me know how we should proceed with that one. As mentioned on Slack, I consider this important because using images in card's seems to be a pretty common thing.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 20, 2018
@jelbourn jelbourn merged commit 89d16b2 into angular:master Aug 23, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
* Fixes that `mat-card-$breakpoint-image` images overlap the card content when placed inside of the title group.

Fixes #10031
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mat-card-lg-image (mat-card-title-group) overlaps content in mat-card-content
3 participants