-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): images in title-group overlapping content #12205
fix(card): images in title-group overlapping content #12205
Conversation
* Fixes that `mat-card-$breakpoint-image` images overlap the card content when placed inside of the title group. Fixes angular#10031
Would it be simpler to just make the |
I think it would be good to bring this change without breaking changes into the next patch release. The extra CSS to avoid the breaking change is pretty small and can be removed and made consistent as soon as we make breaking changes. For now the high priority is just to fix the images overlapping the content when used inside of a title group (also |
@jelbourn Please let me know how we should proceed with that one. As mentioned on Slack, I consider this important because using images in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fixes that `mat-card-$breakpoint-image` images overlap the card content when placed inside of the title group. Fixes #10031
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
mat-card-$breakpoint-image
images overlap the card content when placed inside of the title group.@jelbourn Made it in a way that should be non-breaking for those using the
xl-image
outside of themat-card-title-group
. For those who use it inside of the title-group it can be considered a normal issue fix.Fixes #10031