Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): disable focus overlay for touch focus #12249

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

crisbeto
Copy link
Member

Doesn't show the tab's focus indication if it was focused by anything, other than keyboard or programmatically.

Fixes #12247.

Doesn't show the tab's focus indication if it was focused by anything, other than keyboard or programmatically.

Fixes angular#12247.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 17, 2018
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 17, 2018 18:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 17, 2018
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 7, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 1b19b93 into angular:master Aug 23, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
Doesn't show the tab's focus indication if it was focused by anything, other than keyboard or programmatically.

Fixes #12247.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs should not keep focus on touch screen
4 participants