-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio): align with 2018 material design spec #12299
Conversation
.mat-radio-inner-circle, | ||
.mat-radio-ripple .mat-ripple-element:not(.mat-radio-persistent-ripple), | ||
&.mat-radio-checked .mat-radio-persistent-ripple, | ||
&:active .mat-radio-persistent-ripple { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment with the different states would be probably nice here, but not required 😄
6ed07c9
to
b52cf1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b52cf1c
to
0e2dd1b
Compare
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Aligns the radio button with the latest iteration of the Material spec. The radio itself was mostly aligned, but these changes introduce ripples hover, as well as varying opacity for the focused and active ripples.
0e2dd1b
to
7ffa194
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Aligns the radio button with the latest iteration of the Material spec. The radio itself was mostly aligned, but these changes introduce ripples hover, as well as varying opacity for the focused and active ripples.