Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): align with 2018 material design spec #12299

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

crisbeto
Copy link
Member

Aligns the radio button with the latest iteration of the Material spec. The radio itself was mostly aligned, but these changes introduce ripples hover, as well as varying opacity for the focused and active ripples.

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Jul 20, 2018
@crisbeto crisbeto requested a review from devversion as a code owner July 20, 2018 18:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2018
.mat-radio-inner-circle,
.mat-radio-ripple .mat-ripple-element:not(.mat-radio-persistent-ripple),
&.mat-radio-checked .mat-radio-persistent-ripple,
&:active .mat-radio-persistent-ripple {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment with the different states would be probably nice here, but not required 😄

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 20, 2018
@ngbot
Copy link

ngbot bot commented Jul 20, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto force-pushed the radio-spec-alignment branch from 6ed07c9 to b52cf1c Compare July 20, 2018 20:00
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto force-pushed the radio-spec-alignment branch from b52cf1c to 0e2dd1b Compare July 28, 2018 11:48
@crisbeto crisbeto changed the title refactor(radio): align with new material spec feat(radio): align with 2018 material design spec Jul 28, 2018
@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Aug 14, 2018
@ngbot
Copy link

ngbot bot commented Aug 21, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

Aligns the radio button with the latest iteration of the Material spec. The radio itself was mostly aligned, but these changes introduce ripples hover, as well as varying opacity for the focused and active ripples.
@crisbeto crisbeto force-pushed the radio-spec-alignment branch from 0e2dd1b to 7ffa194 Compare August 22, 2018 17:12
@jelbourn jelbourn merged commit dda8122 into angular:master Aug 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants