Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tooltip): align with 2018 material design spec #12310

Merged
merged 1 commit into from
Jul 29, 2018
Merged

feat(tooltip): align with 2018 material design spec #12310

merged 1 commit into from
Jul 29, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 21, 2018 •
edited
Loading

Adjusts the tooltip to align it with the new Material design spec.

angular_material_-_google_chrome_2018-07-24_20-04-43
angular_material_-_google_chrome_2018-07-24_20-13-21

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Jul 21, 2018
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 21, 2018 15:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2018
jelbourn
jelbourn approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 24, 2018
@jelbourn
Copy link
Member

Caretaker note: probably not a lot of screenshot tests capture tooltips, but something to be aware of

@jelbourn
Copy link
Member

Almost forgot, could you also change the commit to feat so that ti shows up in the changelog?

@crisbeto crisbeto force-pushed the tooltip-spec-update branch from 2f4e02f to c141583 Compare July 24, 2018 18:14
@crisbeto crisbeto changed the title refactor(tooltip): align with new material spec refactor(tooltip): align with 2018 material design spec Jul 24, 2018
@crisbeto
feat(tooltip): align with 2018 material design spec
bcfb480 
Adjusts the tooltip to align it with the new Material design spec.
@crisbeto crisbeto force-pushed the tooltip-spec-update branch from c141583 to bcfb480 Compare July 24, 2018 18:14
@crisbeto crisbeto changed the title refactor(tooltip): align with 2018 material design spec feat(tooltip): align with 2018 material design spec Jul 24, 2018
@mmalerba mmalerba merged commit 4e358c3 into angular:master Jul 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba