Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(progress-bar): align with 2018 material design spec #12394

Merged
merged 1 commit into from
Aug 16, 2018
Merged

feat(progress-bar): align with 2018 material design spec #12394

merged 1 commit into from
Aug 16, 2018

Conversation

crisbeto
Copy link
Member

Aligns the progress bar component with the latest version of the Material design spec.

For reference:

angular_material_-_google_chrome_2018-07-26_23-18-48
angular_material_-_google_chrome_2018-07-26_23-18-56

@crisbeto
feat(progress-bar): align with 2018 material design spec
f64af94 
Aligns the progress bar component with the latest version of the Material design spec.
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Jul 26, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 26, 2018
jelbourn
jelbourn approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 26, 2018
josephperrott
josephperrott approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Aug 14, 2018
@mmalerba mmalerba merged commit b2247f8 into angular:master Aug 16, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @josephperrott @googlebot @mmalerba