Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): disable hover styling on touch devices #12520

Merged
merged 1 commit into from
Aug 7, 2018
Merged

fix(list): disable hover styling on touch devices #12520

merged 1 commit into from
Aug 7, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 3, 2018

  • Disables the list hover styles on touch devices since it tends to behave like focus and it tends to get stuck after tapping on an item.
  • Disables the WebKit touch overlays to avoid the black overlay when tapping on selection lists.

@crisbeto
fix(list): disable hover styling on touch devices
b12b0e5 
* Disables the list hover styles on touch devices since it tends to behave like focus and it tends to get stuck after tapping on an item.
* Disables the WebKit touch overlays to avoid the black overlay when tapping on selection lists.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 3, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 3, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 3, 2018
jelbourn
jelbourn approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit 795c956 into angular:master Aug 7, 2018
josephperrott pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @josephperrott
fix(list): disable hover styling on touch devices (#12520)
08a319d
josephperrott pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @josephperrott
fix(list): disable hover styling on touch devices (#12520)
6048f6f
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @googlebot @josephperrott