Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): allow transition for the button focus overlay for all buttons #12552

Merged
merged 1 commit into from
Aug 7, 2018
Merged

fix(button): allow transition for the button focus overlay for all buttons #12552

merged 1 commit into from
Aug 7, 2018

Conversation

josephperrott
Copy link
Member

Fixes #12513

@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Aug 6, 2018
@josephperrott josephperrott requested a review from jelbourn August 6, 2018 17:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 6, 2018
jelbourn
jelbourn approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 6, 2018
@josephperrott josephperrott merged commit a080a79 into angular:master Aug 7, 2018
@josephperrott josephperrott deleted the button-focus-animation branch August 7, 2018 20:37
josephperrott added a commit that referenced this pull request Aug 7, 2018
@josephperrott
fix(button): allow transition for the button focus overlay for all bu…
0a56cf7 
…ttons (#12552)
josephperrott added a commit that referenced this pull request Aug 7, 2018
@josephperrott
fix(button): allow transition for the button focus overlay for all bu…
6885c1a 
…ttons (#12552)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add transition on mat-button-focus-overlay for mat-button
3 participants
@josephperrott @jelbourn @googlebot