Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): improved alignment for step icons #12703

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

crisbeto
Copy link
Member

Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes #12696.

For reference, the first screenshot is what it looks like in master:

angular_material_-_google_chrome_2018-08-16_20-02-56
angular_material_-_google_chrome_2018-08-16_20-01-46

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 16, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner August 16, 2018 18:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 16, 2018
Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes angular#12696.
@crisbeto crisbeto force-pushed the 12696/step-header-alignment branch from 36d8502 to ca6b26a Compare August 16, 2018 18:40
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 23, 2018
@jelbourn jelbourn merged commit 37a7056 into angular:master Aug 24, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes #12696.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment issue with Stepper's numbers
4 participants