fix(chips): chip list removing focus from first chip when adding through the input

[crisbeto]

Something I ran into while aligning the chips with the new spec, which seems to have been introduced in 3da390e. Currently when the user removes all the chips and then they add a new chip, the chip list will remove focus from the input and put it on the chip. These changes introduce the proper behavior, which is to keep focus on the input.

[crisbeto]

Marking as a P2, because it's a regression.

[devversion]

LGTM. Makes sense to get it in before 3da390e will be published. Though not sure if it can be considered a regression if the general focus restoring (through click) didn't work before at all 😄

[jelbourn]

Ah, this might explain why that earlier change was causing a failing that's been blocking the sync...

[jelbourn]

Wow, yeah, that was the issue. Turns out exactly one e2e test in all of Google caught it.

[devversion]

That's good news. I just don't understand why no test actually covered that clicking on the chip remove button does return focus always to the first chip (which is incorrect)

[jelbourn]

That's the nature of things- we do our best to test every scenario, but something will always be forgotten. As long as we add tests with every fix things will always get better.

[crisbeto]

FWIW, I think the other tests didn't catch it, because they're usually resetting the chips programmatically, but this only happens when you've removed all the chips using backspace.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}