fix(schematics): generated spec files not working #12842
Conversation
If someone generates components with Angular Material by using our schematics and runs `ng test` afterwards, the tests will fail because: * The needed Material modules are not being imported * No animation module is specified (either `Noop` or `BrowserAnimationsModule`) * `fakeAsync` is used to run `compileComponents`. `async()` should be used to wait for `compileComponents` (see the default CLI component schematic) Fixes angular#12778
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
Side-note that's not necessarily related to this PR, but should we set something up on the CI that runs the schematics and verifies that they actually do what they're supposed to? Right now it can be hard to execute the template files in your head, in order to figure out whether they're working correctly. |
|
Definitely. We actually run tests that verify the schematics (as good as possible). Right now the big priority is the update tool though. I will be working on some improved testing once the update tool is ready. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If someone generates components with Angular Material by using our schematics and runs
ng testafterwards, the tests will fail because:NooporBrowserAnimationsModule)fakeAsyncis used to runcompileComponents.async()should be used to wait forcompileComponents(see the default CLI component schematic)Fixes #12778