feat(datepicker): remove dependency on mat-dialog #13019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
datepicker-dialog-decouple
branch
from
b53813c to
8c915e9
Compare
mmalerba
approved these changes
Oct 2, 2018
src/lib/datepicker/datepicker.ts
Outdated
|
|
||
| if (!this.touchUi) { | ||
| // Update the position once the calendar has rendered. | ||
| this._ngZone.onStable.asObservable() |
There was a problem hiding this comment.
I think we can leave off the .asObservable()
There was a problem hiding this comment.
I've been doing this since, at some point in the past, omitting it ended up causing a memory leak. I'm not sure whether that hasn't been fixed in core by now though.
There was a problem hiding this comment.
Ah ok, didn't realize that
crisbeto
force-pushed
the
datepicker-dialog-decouple
branch
from
8c915e9 to
3164d94
Compare
crisbeto
force-pushed
the
datepicker-dialog-decouple
branch
from
3164d94 to
43a29b5
Compare
crisbeto
force-pushed
the
datepicker-dialog-decouple
branch
from
43a29b5 to
79fdefe
Compare
|
What is status of this? Do you plan to merge this? We would like to use touchUi but we have a few issues related to dialog and #7390. (mostly on ios safari) |
Reworks the datepicker to remove its dependency to `material/dialog`, avoiding bringing in all of the overhead of the dialog from which the datepicker is using a small fraction.
crisbeto
force-pushed
the
datepicker-dialog-decouple
branch
from
79fdefe to
abd743a
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 1, 2021
Currently the datepicker has a hard dependency on `MatDialog` due to its touch-specific appearance which makes it difficult to use together with the MDC packages, because they have an alternate dialog module. These changes resolve the issue by removing the datepicker's dependency on `MatDialog`. The approach is loosely based on angular#13019, however I've simplified things a bit to make it more maintainable.
|
Closing in favor of #22383. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 8, 2021
Currently the datepicker has a hard dependency on `MatDialog` due to its touch-specific appearance which makes it difficult to use together with the MDC packages, because they have an alternate dialog module. These changes resolve the issue by removing the datepicker's dependency on `MatDialog`. The approach is loosely based on angular#13019, however I've simplified things a bit to make it more maintainable.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 8, 2021
Currently the datepicker has a hard dependency on `MatDialog` due to its touch-specific appearance which makes it difficult to use together with the MDC packages, because they have an alternate dialog module. These changes resolve the issue by removing the datepicker's dependency on `MatDialog`. The approach is loosely based on angular#13019, however I've simplified things a bit to make it more maintainable.
mmalerba
pushed a commit
that referenced
this pull request
Apr 13, 2021
Currently the datepicker has a hard dependency on `MatDialog` due to its touch-specific appearance which makes it difficult to use together with the MDC packages, because they have an alternate dialog module. These changes resolve the issue by removing the datepicker's dependency on `MatDialog`. The approach is loosely based on #13019, however I've simplified things a bit to make it more maintainable.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the datepicker to remove its dependency to
material/dialog, avoiding bringing in all of the overhead of the dialog from which the datepicker is using a small fraction.