Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(card): uneven action button margin #13390

Closed
wants to merge 1 commit into from
Closed

fix(card): uneven action button margin #13390

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 2, 2018

Fixes the margin between the first action button all the other not being even. Also fixes the margin not being reset on the last button when using align="end".

Fixes #13382.

For reference:
before
after

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 2, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner October 2, 2018 18:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2018
@jelbourn jelbourn added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Oct 2, 2018
jelbourn
jelbourn previously approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Dec 7, 2018
@crisbeto crisbeto force-pushed the 13382/card-uneven-margin branch from 1d8cd00 to 63bba7e Compare December 13, 2018 17:46
@crisbeto crisbeto force-pushed the 13382/card-uneven-margin branch from 63bba7e to 1b77d64 Compare December 28, 2018 15:53
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 30, 2019
@crisbeto crisbeto force-pushed the 13382/card-uneven-margin branch from 1b77d64 to 8c5ff3a Compare July 1, 2019 20:17
@crisbeto crisbeto force-pushed the 13382/card-uneven-margin branch from 8c5ff3a to 49fb764 Compare July 22, 2019 21:16
@crisbeto crisbeto force-pushed the 13382/card-uneven-margin branch from 49fb764 to 3a5b9fd Compare August 31, 2019 08:22
@crisbeto crisbeto mentioned this pull request Aug 31, 2019
Closed
@crisbeto
fix(card): uneven action button margin
4ffaf13 
Fixes the margin between the first action button all the other not being even. Also fixes the margin not being reset on the last button when using `align="end"`.

Fixes angular#13382.
@crisbeto crisbeto force-pushed the 13382/card-uneven-margin branch from 3a5b9fd to 4ffaf13 Compare March 22, 2020 18:16
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@andrewseguin andrewseguin removed the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 28, 2022
@andrewseguin andrewseguin assigned crisbeto and unassigned jelbourn Apr 22, 2022
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@mmalerba mmalerba self-assigned this Nov 28, 2022
@mmalerba
Copy link
Contributor

Closing since this fix is for the legacy mat-card which has been superseded by the MDC based one.

@mmalerba mmalerba closed this Nov 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees

@mmalerba mmalerba

Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-card-actions has inconsistent spacing
6 participants
@crisbeto @mmalerba @jelbourn @googlebot @josephperrott @andrewseguin