fix(menu): unable to swap menu panel after first open #13819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
menu-panel-swap
branch
from
a3b0260 to
3a805ff
Compare
Fixes the menu trigger being locked into the first menu panel that is passed in, after it has been opened at least once. Relates to angular#13812.
crisbeto
force-pushed
the
menu-panel-swap
branch
from
3a805ff to
fc5f5d3
Compare
jelbourn
added
pr: lgtm
action: merge
diicar
reviewed
Oct 26, 2018
|
|
||
| if (menu) { | ||
| this._menuCloseSubscription = menu.close.asObservable().subscribe(reason => { | ||
| this._destroyMenu(); |
There was a problem hiding this comment.
I believe that you need to add this._menuCloseSubscription here to this._cleanUpSubscriptions();
There was a problem hiding this comment.
It's not required, because the close stream gets completed when the menu panel is destroyed.
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
Fixes the menu trigger being locked into the first menu panel that is passed in, after it has been opened at least once. Relates to angular#13812.
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
Fixes the menu trigger being locked into the first menu panel that is passed in, after it has been opened at least once. Relates to #13812.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the menu trigger being locked into the first menu panel that is passed in, after it has been opened at least once.
Relates to #13812.