fix(radio): host element unable to receive focus events #13956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable. Fixes angular#13953.
crisbeto
force-pushed
the
13953/radio-non-focusable
branch
from
e91f0a1 to
3cf228d
Compare
mmalerba
pushed a commit
that referenced
this pull request
Dec 10, 2018
In #13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable. Fixes #13953.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
…)" This reverts commit 41eb27e.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
…)" This reverts commit 41eb27e.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
…from ListKeyManager" (#14467) * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (#13956)" This reverts commit 41eb27e. * Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager (#14407)" This reverts commit 014dc79.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
) * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (#13956)" This reverts commit 41eb27e.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
…from ListKeyManager" (#14467) * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (#13956)" This reverts commit 41eb27e. * Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager (#14407)" This reverts commit 014dc79.
mmalerba
added a commit
that referenced
this pull request
Dec 11, 2018
) * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (#13956)" This reverts commit 41eb27e.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable. Fixes angular#13953.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…from ListKeyManager" (angular#14467) * Revert "build: update sauce connect (angular#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (angular#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (angular#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (angular#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (angular#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (angular#13956)" This reverts commit 41eb27e. * Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager (angular#14407)" This reverts commit 014dc79.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ular#14468) * Revert "Revert "fix(a11y): activeItem out of date if active index is removed from ListKeyManager" (angular#14467)" This reverts commit 8f790f5. * Revert "build: update sauce connect (angular#14422)" This reverts commit bc563b7. * Revert "build: changelog script not filtering duplicate entries (angular#14421)" This reverts commit fe46290. * Revert "build: update to angular 7.1.2 (angular#14418)" This reverts commit e1487df. * Revert "refactor(drag-drop): move logic out of directives (angular#14350)" This reverts commit 19f9bca. * Revert "fix(checkbox): redirect focus to underlying input element (angular#13959)" This reverts commit e0eb3df. * Revert "fix(radio): host element unable to receive focus events (angular#13956)" This reverts commit 41eb27e.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13323 we started clearing the
tabindexfrom thehostelement in order to avoid having two elements with the sametabindexwhen the consumer sets a customtabindex. As a result, themat-radio-buttoncan no longer receive focus and forward it to theinput. These changes always reset thetabindexto -1 so the element is focusable, but not tabbable.Fixes #13953.