Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump to 7.0.3 w/ changelog #13999

Merged
merged 3 commits into from
Nov 6, 2018
Merged

chore: bump to 7.0.3 w/ changelog #13999

merged 3 commits into from
Nov 6, 2018

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 6, 2018

No description provided.

@jelbourn jelbourn added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 6, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2018
crisbeto
crisbeto approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 6, 2018
@ngbot
Copy link

ngbot bot commented Nov 6, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

josephperrott
josephperrott approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
chrore: adding missing browserstack test script
4ce71c6 
For some reason that was missing after cherrypicking patch changes
@jelbourn
Add missing browserstack circle files
d8febf7
@jelbourn jelbourn merged commit 44db886 into angular:7.0.x Nov 6, 2018
josephperrott pushed a commit that referenced this pull request Nov 13, 2018
@jelbourn @josephperrott
chore: bump to 7.0.3 w/ changelog (#13999)
89bb692 
Also adds browserstack ci changes that didn't get cherrypicked for some reason
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jelbourn @crisbeto @devversion @josephperrott @googlebot