fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled #14414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y if the floating label is disabled Fixes the first option not appearing as highlighted if the consumer has set `floatLabel="never"` and `autoActiveFirstOption`. It looks like we were depending on the `transitioned` event from the label to kick off the change detection that shows the highlight. Fixes angular#13734.
crisbeto
added
merge: caretaker note
googlebot
added
the
cla: yes
|
Caretaker note: this is a resubmit of #13774 which had to be reverted due to sync issues. |
vivian-hu-zz
added a commit
that referenced
this pull request
Dec 13, 2018
…correctly if the floating label is disabled" (#14505) * Revert "Revert "fix(snack-bar): announcing same message twice to screen readers" (#14494)" This reverts commit e9466a4. * Revert "Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes" (#14492)" This reverts commit 3eb7e9c. * Revert "Revert "fix(menu): allow text wrapping in menu items" (#14493)" This reverts commit a3da8d2. * Revert "build: update nodejs bazel rules (#14466)" This reverts commit a3fef46. * Revert "docs(form-field): native select reset values not working in examples (#14236)" This reverts commit 97f52c0. * Revert "fix(menu): allow text wrapping in menu items (#11430)" This reverts commit 3661abe. * Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes (#13065)" This reverts commit fe96f38. * Revert "build: replace deprecated tslint rule with compiler option (#13186)" This reverts commit 5dfa45f. * Revert "fix(snack-bar): announcing same message twice to screen readers (#13298)" This reverts commit 3fb4b23. * Revert "feat(drag-drop): allow entire group of drop lists to be disabled (#14179)" This reverts commit 94e76de. * Revert "fix(drag-drop): prevent text selection while dragging on Safari (#14405)" This reverts commit 220e388. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#14414)" This reverts commit 53d2b58.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…y if the floating label is disabled (angular#14414) Fixes the first option not appearing as highlighted if the consumer has set `floatLabel="never"` and `autoActiveFirstOption`. It looks like we were depending on the `transitioned` event from the label to kick off the change detection that shows the highlight. Fixes angular#13734.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…correctly if the floating label is disabled" (angular#14505) * Revert "Revert "fix(snack-bar): announcing same message twice to screen readers" (angular#14494)" This reverts commit e9466a4. * Revert "Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes" (angular#14492)" This reverts commit 3eb7e9c. * Revert "Revert "fix(menu): allow text wrapping in menu items" (angular#14493)" This reverts commit a3da8d2. * Revert "build: update nodejs bazel rules (angular#14466)" This reverts commit a3fef46. * Revert "docs(form-field): native select reset values not working in examples (angular#14236)" This reverts commit 97f52c0. * Revert "fix(menu): allow text wrapping in menu items (angular#11430)" This reverts commit 3661abe. * Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes (angular#13065)" This reverts commit fe96f38. * Revert "build: replace deprecated tslint rule with compiler option (angular#13186)" This reverts commit 5dfa45f. * Revert "fix(snack-bar): announcing same message twice to screen readers (angular#13298)" This reverts commit 3fb4b23. * Revert "feat(drag-drop): allow entire group of drop lists to be disabled (angular#14179)" This reverts commit 94e76de. * Revert "fix(drag-drop): prevent text selection while dragging on Safari (angular#14405)" This reverts commit 220e388. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#14414)" This reverts commit 53d2b58.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first option not appearing as highlighted if the consumer has set
floatLabel="never"andautoActiveFirstOption. It looks like we were depending on thetransitionedevent from the label to kick off the change detection that shows the highlight.Fixes #13734.