fix(drag-drop): update root element if selector changes #14426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto passes presubmit, just needs rebase |
Currently the root element is only resolved once on init, however since it's an input, it could change. These changes add some logic to keep the element up to date.
crisbeto
force-pushed
the
drag-drop-root-selector-update
branch
from
75b1490 to
9470334
Compare
|
Rebased @jelbourn. |
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Currently the root element is only resolved once on init, however since it's an input, it could change. These changes add some logic to keep the element up to date.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the root element is only resolved once on init, however since it's an input, it could change. These changes add some logic to keep the element up to date.