-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dialog,bottom-sheet): invert backdrop color on dark themes #14502
Conversation
badb974
to
f61d2df
Compare
@crisbeto it looks like this is changing the backdrop color for light themes as well, which is causing a lot of screenshot diffs |
f61d2df
to
6e94a4b
Compare
Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.
6e94a4b
to
42e1961
Compare
AFAIK this isn't in the spec. Closing. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.
Note: this is a resubmit of #13065.