Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog,bottom-sheet): invert backdrop color on dark themes #14502

Closed

Conversation

crisbeto
Copy link
Member

Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.

Note: this is a resubmit of #13065.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 13, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner December 13, 2018 17:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2018
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 13, 2018
@ngbot
Copy link

ngbot bot commented Dec 13, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto force-pushed the dialog-invert-backdrop-resubmit branch from badb974 to f61d2df Compare December 17, 2018 21:55
@jelbourn
Copy link
Member

@crisbeto it looks like this is changing the backdrop color for light themes as well, which is causing a lot of screenshot diffs

@crisbeto crisbeto force-pushed the dialog-invert-backdrop-resubmit branch from f61d2df to 6e94a4b Compare December 28, 2018 15:54
@mmalerba mmalerba added the aaa label Apr 25, 2019
@mmalerba mmalerba removed the aaa label Apr 25, 2019
Similarly to how we handle the sidenav backdrop and ripples, these changes invert the color for the dialog and bottom sheet backdrops in dark themes.
@crisbeto crisbeto force-pushed the dialog-invert-backdrop-resubmit branch from 6e94a4b to 42e1961 Compare June 19, 2019 20:39
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@crisbeto
Copy link
Member Author

AFAIK this isn't in the spec. Closing.

@crisbeto crisbeto closed this Feb 28, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants