fix(datepicker): native date adapter not preserving time when cloning #14691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
approved these changes
Jan 2, 2019
mmalerba
reviewed
Jan 3, 2019
| @@ -146,7 +146,7 @@ export class NativeDateAdapter extends DateAdapter<Date> { | |||
| } | |||
|
|
|||
| clone(date: Date): Date { | |||
| return this.createDate(this.getYear(date), this.getMonth(date), this.getDate(date)); | |||
| return new Date(date); | |||
There was a problem hiding this comment.
For some reason in google3 it complains about Argument of type 'Date' is not assignable to parameter of type 'string | number'. Instead maybe you can do new Date(date.getTime())
When the `NativeDateAdapter` clones a date, it creates the clone only from the year, month and day which means that the clone's time will be different from the source.
crisbeto
force-pushed
the
native-date-adapter-clone
branch
from
001ff6f to
9a51a2c
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…angular#14691) When the `NativeDateAdapter` clones a date, it creates the clone only from the year, month and day which means that the clone's time will be different from the source.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
NativeDateAdapterclones a date, it creates the clone only from the year, month and day which means that the clone's time will be different from the source.