Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon): allow viewBox to be configured when registering icons #16320

Merged
merged 1 commit into from
Jul 19, 2019
Merged

feat(icon): allow viewBox to be configured when registering icons #16320

merged 1 commit into from
Jul 19, 2019

Conversation

crisbeto
Copy link
Member

This has been a long-standing feature request that has recently popped up again. Allows consumers to specify a viewBox for icons and icon sets when they're being registered.

Fixes #2981.
Fixes #16293.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release labels Jun 18, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner June 18, 2019 20:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 18, 2019
jelbourn
jelbourn reviewed Jun 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was something I had been holding off on because I wanted it to be part of cdk-svg, but it's probably going to be a while before we can really do that, so we might as well do it here

@crisbeto
feat(icon): allow viewBox to be configured when registering icons
f378393 
This has been a long-standing feature request that has recently popped up again. Allows consumers to specify a `viewBox` for icons and icon sets when they're being registered.

Fixes angular#2981.
Fixes angular#16293.
@crisbeto crisbeto force-pushed the 2981/icon-registry-viewbox branch from 550bbc7 to f378393 Compare June 30, 2019 08:14
@crisbeto
Copy link
Member Author

Reworked based on the feedback @jelbourn.

jelbourn
jelbourn approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 1, 2019
@jelbourn jelbourn merged commit 3638886 into angular:master Jul 19, 2019
@Sl1MBoy
Copy link

Sl1MBoy commented Aug 26, 2019

Also would be nice to use the viewBox attribute of the symbol If already set.

@Sl1MBoy Sl1MBoy mentioned this pull request Aug 27, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
4 participants
@crisbeto @Sl1MBoy @jelbourn @googlebot