perf(progress-circle): improved rendering performance #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 27, 2016
| * Renders the arc onto the SVG element. Proxies `getArc` while setting the proper | ||
| * DOM attribute on the `<path>`. | ||
| * @param {number} currentValue Current value to be rendered. | ||
| * @param {number} rotation Rotation of the circle. |
There was a problem hiding this comment.
Remove the types from the JsDoc, since they're just part of the code.
crisbeto
force-pushed
the
progress-circle-perf
branch
from
e5b8800 to
c45c874
Compare
Currently the progress circle hits ZoneJS on every animation frame, due to `requestAnimationFrame`. This change: * Wraps the `requestAnimationFrame` calls in `runOutsideAngular` in order to avoid hitting the change detection on every frame. * Switches from using an attribute binding to manipulating the `path` node directly. Referencing angular#1570, angular#1511.
crisbeto
force-pushed
the
progress-circle-perf
branch
from
c45c874 to
2f4976b
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the progress circle hits ZoneJS on every animation frame, due to
requestAnimationFrame. This change:requestAnimationFramecalls inrunOutsideAngularin order to avoid hitting the change detection on every frame.pathnode directly.Referencing #1570, #1511.
Note: I'm open to suggestions on better ways to fetch a reference to the
pathnode. I've tried doing it in the constructor and in anOnInitmethod, but certain animations fire too early for the element to be rendered.