feat(google-maps): add google-map component #16623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbehrlich
requested review from
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
Splaktar
reviewed
Jul 30, 2019
Splaktar
added
new component
jelbourn
reviewed
Aug 1, 2019
|
Also, sorry for all the merge conflicts; I just merged the youtube-player |
lacolaco
reviewed
Aug 1, 2019
|
|
||
| this._mapEl$.pipe(take(1)).subscribe(mapElRef => { | ||
| const mapEl = mapElRef.nativeElement; | ||
| mapEl.style.height = this.height; |
There was a problem hiding this comment.
Is this.height applied to the map only once at onInit?
There was a problem hiding this comment.
Currently, yes. I think it's a good idea to make it capable of being resized, but I'd like to add that functionality, along with that of the other required inputs, in a future pull request.
Add initial infrastructure for angular/google-maps, a skeleton for the google-map component, and a demo for the google map component
Fix lint issues. Fix overviews bazel rule typo.
Fix e2e tests
Fix commas in tsconfig files
Add @angular/google-maps/google-map path to tsconfig-build.json
Fix incorrect dev-app path for google-maps
Change default location to Colossem, change map element view child to not be a stream. Minor style changes.
Change default map location to Googleplex. Remove ViewChild from google-map component.
jelbourn
added
pr: lgtm
action: merge
Splaktar
reviewed
Aug 2, 2019
Clean up the demo component with better variable names and remove extraneous code.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial infrastructure for angular/google-maps,
a skeleton for the google-map component, and a demo
for the google map component