feat(paginator): Use en dash in MatPaginatorIntl

[paulferaud]

Number ranges should be formatted with en dash.

Technically, there should be no spaces either: https://www.thepunctuationguide.com/en-dash.html
But since this isn’t a sentence, I think the spaces are fine (It’s also a less disruptive change, while still going in the right direction).

BREAKING CHANGE: MatPaginatorIntl will now cause MatPaginator to display
an 'EN DASH' (U+2013) rather than a 'HYPHEN-MINUS' (U+002D)

[crisbeto]

Seems reasonable to me, but I can see it triggering a bunch of screenshot test failures. Leaving it up to @jelbourn and @andrewseguin for final approval.

[jelbourn]

LGTM

We'll see how breaking it ends up being.

[mmalerba]

This results in ~100 targets failing, a combination of screen diffs and unit tests comparing against strings like '1 - 2'

[jelbourn]

Since it causes so many breakages, this probably won't get merged for a long time (unless you want to do the work of getting it green inside Google, @paulferaud)

[paulferaud]

@jelbourn As in just getting all tests inside Google in a state where they would pass with or without this change? Or is there a more manageable process?

I don’t think I can single single handedly fix 100 tests in such a way...

[jelbourn]

For that many, yes, it would probably be getting affected the tests to pass either way and then also updating the screenshots affected. It's ultimately a lot of work for a small change.

[paulferaud]

Alright. Would be nice to get this in eventually.

Hopefully, we could migrate a log of people to use the newer Xap paginator, which would alleviate the breakage.

[andrewseguin]

Took quite a lot of test and screenshot changes but we got a passing test run 👍

[paulferaud]

That’s amazing! I was ready to give up on this. Thanks a lot!

PS: I saw the CL. Glad we could do this as a 1 shot.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}