Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk-experimental): expose root loader instance in harness environment #16903

Merged

Conversation

devversion
Copy link
Member

Adds a new method that can be used by harness consumers to load a harness
through HarnessLoader from the document root. This is helpful for harnesses
which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.).

Needed for #16697 and #16709.

@mmalerba I just took a stab at implementing this as we discussed this on the PR (#16697 (comment)) and in the team meeting. I wanted to unblock my other harness PRs.

@devversion devversion added the target: patch This PR is targeted for the next patch release label Aug 28, 2019
@devversion devversion requested a review from mmalerba as a code owner August 28, 2019 13:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 28, 2019
@devversion devversion force-pushed the feat/cdk-experimental-expose-root-loader branch 2 times, most recently from 8138e80 to 9a44d8a Compare August 29, 2019 14:15
@mmalerba mmalerba added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 30, 2019
@ngbot
Copy link

ngbot bot commented Aug 30, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
Copy link
Contributor

CARETAKER NOTE: The new static method and its corresponding test also needs to be added to the CatalystHarnessEnvironment

@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Aug 30, 2019
@mmalerba
Copy link
Contributor

mmalerba commented Sep 4, 2019

#16709 was accidentally merged early and remove the protected on the constructor for TestbedHarnessEnvironment. Please add it back in this PR and switch the test to use the new method instead

@devversion devversion force-pushed the feat/cdk-experimental-expose-root-loader branch from 9a44d8a to 9a0272f Compare September 5, 2019 08:30
@devversion
Copy link
Member Author

@mmalerba Good catch. Updated!

@devversion devversion force-pushed the feat/cdk-experimental-expose-root-loader branch from 9a0272f to 97c0dd8 Compare September 6, 2019 12:01
@jelbourn
Copy link
Member

@devversion could you rebase?

@mmalerba mmalerba added this to the 9.0.0 milestone Sep 17, 2019
@devversion devversion force-pushed the feat/cdk-experimental-expose-root-loader branch from 97c0dd8 to dcc3bf7 Compare September 17, 2019 17:01
@devversion devversion force-pushed the feat/cdk-experimental-expose-root-loader branch from dcc3bf7 to bfc44a4 Compare September 17, 2019 17:04
…s environment

Adds a new method that can be used by harness consumers to load a harness
through `HarnessLoader` from the document root. This is helpful for harnesses
which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.).

Needed for angular#16697 and angular#16709.
@devversion devversion force-pushed the feat/cdk-experimental-expose-root-loader branch from bfc44a4 to ebd7a8b Compare September 17, 2019 17:53
@jelbourn jelbourn merged commit 3765433 into angular:master Sep 17, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
…s environment (angular#16903)

Adds a new method that can be used by harness consumers to load a harness
through `HarnessLoader` from the document root. This is helpful for harnesses
which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.).

Needed for angular#16697 and angular#16709.

(cherry picked from commit 3765433)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants