-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk-experimental): expose root loader instance in harness environment #16903
feat(cdk-experimental): expose root loader instance in harness environment #16903
Conversation
8138e80
to
9a44d8a
Compare
CARETAKER NOTE: The new static method and its corresponding test also needs to be added to the |
#16709 was accidentally merged early and remove the |
9a44d8a
to
9a0272f
Compare
@mmalerba Good catch. Updated! |
9a0272f
to
97c0dd8
Compare
@devversion could you rebase? |
97c0dd8
to
dcc3bf7
Compare
dcc3bf7
to
bfc44a4
Compare
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
bfc44a4
to
ebd7a8b
Compare
…s environment (angular#16903) Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709. (cherry picked from commit 3765433)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a new method that can be used by harness consumers to load a harness
through
HarnessLoader
from the document root. This is helpful for harnesseswhich need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.).
Needed for #16697 and #16709.
@mmalerba I just took a stab at implementing this as we discussed this on the PR (#16697 (comment)) and in the team meeting. I wanted to unblock my other harness PRs.