Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/snack-bar): add test harness for snack-bar #17127

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

devversion
Copy link
Member

Resubmit of #16697 which was blocked on the documentRootLoader PR that got in recently.

Also reworked the PR to add the test harness to material to avoid another PR to move it later. Let me know if this is preferred.

@devversion devversion requested review from crisbeto, jelbourn and a team as code owners September 18, 2019 13:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 18, 2019
@devversion devversion force-pushed the feat/test-harness-mdc-snack-bar branch from cfbe548 to 4f7cb04 Compare September 18, 2019 13:23
@devversion devversion added the target: major This PR is targeted for the next major release label Sep 18, 2019
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the move out of experimental!

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 18, 2019
@mmalerba mmalerba merged commit 6a732d3 into angular:master Sep 18, 2019
@devversion devversion added this to the 9.0.0 milestone Sep 18, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants