fix(form-field): outline gap not calculated in shadow dom #17303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we check whether the form field is inside the DOM using `documentElement.contains(formField)` so that we don't try to calculate the outline gap. The problem is that `contains` won't catch elements inside the shadow DOM. These changes rework the check to use `getRootNode` instead. Fixes angular#17262.
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
changed the title
mmalerba
reviewed
Oct 7, 2019
| @@ -582,4 +582,20 @@ export class MatFormField extends _MatFormFieldMixinBase | |||
| private _getStartEnd(rect: ClientRect): number { | |||
| return this._previousDirection === 'rtl' ? rect.right : rect.left; | |||
| } | |||
|
|
|||
| /** Checks whether the form field is attached to the DOM. */ | |||
| private _isAttachedToDOM(): boolean { | |||
There was a problem hiding this comment.
Do we currently use a similar pattern elsewhere in the library? If so might make sense to put as a utility in cdk or material/core
There was a problem hiding this comment.
I did a quick a search and it doesn't look like we do.
mmalerba
approved these changes
Oct 7, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we check whether the form field is inside the DOM using
documentElement.contains(formField)so that we don't try to calculate the outline gap. The problem is thatcontainswon't catch elements inside the shadow DOM. These changes rework the check to usegetRootNodeinstead.Fixes #17262.