fix(schematics): secondary entry point migration not working against v9 #17452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the secondary entry point migration uses the type checker to figure out which Material module a symbol belongs to. This won't work in v9, because we removed the top-level `@angular/material`. These changes fall back to looking up the name of the symbol in a list of known symbols and their module names. Fixes angular#17433.
googlebot
added
the
cla: yes
crisbeto
commented
Oct 20, 2019
src/material/schematics/ng-update/upgrade-rules/package-imports-v8/material-symbols.json
Show resolved
Hide resolved
...aterial/schematics/ng-update/upgrade-rules/package-imports-v8/secondary-entry-points-rule.ts
Show resolved
Hide resolved
...aterial/schematics/ng-update/upgrade-rules/package-imports-v8/secondary-entry-points-rule.ts
Show resolved
Hide resolved
crisbeto
requested review from
devversion,
jelbourn and
a team
as code owners
crisbeto
added
P1
devversion
approved these changes
Oct 21, 2019
jelbourn
approved these changes
Oct 21, 2019
src/material/schematics/ng-update/upgrade-rules/package-imports-v8/material-symbols.json
Show resolved
Hide resolved
...aterial/schematics/ng-update/upgrade-rules/package-imports-v8/secondary-entry-points-rule.ts
Show resolved
Hide resolved
...aterial/schematics/ng-update/upgrade-rules/package-imports-v8/secondary-entry-points-rule.ts
Show resolved
Hide resolved
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the secondary entry point migration uses the type checker to figure out which Material module a symbol belongs to. This won't work in v9, because we removed the top-level
@angular/material. These changes fall back to looking up the name of the symbol in a list of known symbols and their module names.Fixes #17433.