Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drag-drop): coerce drop list autoScrollDisabled input #17480

Merged
merged 1 commit into from
Oct 28, 2019
Merged

fix(drag-drop): coerce drop list autoScrollDisabled input #17480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/cdk/drag-drop/directives/drop-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,7 @@ export class CdkDropList<T = any> implements AfterContentInit, OnDestroy {

/** Whether sorting within this drop list is disabled. */
@Input('cdkDropListSortingDisabled')
get sortingDisabled(): boolean { return this._sortingDisabled; }
set sortingDisabled(value: boolean) {
this._sortingDisabled = coerceBooleanProperty(value);
}
private _sortingDisabled = false;
sortingDisabled: boolean = false;

/**
* Function that is used to determine whether an item
Expand Down Expand Up @@ -276,8 +272,8 @@ export class CdkDropList<T = any> implements AfterContentInit, OnDestroy {

ref.disabled = this.disabled;
ref.lockAxis = this.lockAxis;
ref.sortingDisabled = this.sortingDisabled;
ref.autoScrollDisabled = this.autoScrollDisabled;
ref.sortingDisabled = coerceBooleanProperty(this.sortingDisabled);
ref.autoScrollDisabled = coerceBooleanProperty(this.autoScrollDisabled);
ref
.connectedTo(siblings.filter(drop => drop && drop !== this).map(list => list._dropListRef))
.withOrientation(this.orientation);
Expand Down