Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): cap maximum elevation for nested menus #17687

Merged
merged 1 commit into from
Nov 25, 2019
Merged

fix(menu): cap maximum elevation for nested menus #17687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/material/menu/menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,9 @@ export class _MatMenuBase implements AfterContentInit, MatMenuPanel<MatMenuItem>
*/
setElevation(depth: number): void {
// The elevation starts at the base and increases by one for each level.
const newElevation = `mat-elevation-z${MAT_MENU_BASE_ELEVATION + depth}`;
// Capped at 24 because that's the maximum elevation defined in the Material design spec.
const elevation = Math.min(MAT_MENU_BASE_ELEVATION + depth, 24);
const newElevation = `mat-elevation-z${elevation}`;
const customElevation = Object.keys(this._classList).find(c => c.startsWith('mat-elevation-z'));

if (!customElevation || customElevation === this._previousElevation) {
Expand Down