refactor(expansion): avoid unnecessary spacing check #17693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: patch
googlebot
added
the
cla: yes
crisbeto
approved these changes
Nov 13, 2019
| @@ -185,7 +185,7 @@ export class MatExpansionPanel extends CdkAccordionItem implements AfterContentI | |||
| // We don't need to subscribe to the `stateChanges` of the parent accordion because each time | |||
| // the [displayMode] input changes, the change detection will also cover the host bindings | |||
| // of this expansion panel. | |||
| return (this.expanded ? this.accordion.displayMode : this._getExpandedState()) === 'default'; | |||
| return this.expanded && this.accordion.displayMode === 'default'; | |||
There was a problem hiding this comment.
I'm not sure the comment above it makes sense anymore either.
There was a problem hiding this comment.
Yeah, I'll remove it since it doesn't seem helpful in that place. I got confused too.
crisbeto
added
pr: lgtm
action: merge
The check where `expanded` equals to `false`, and where the value of the `_getExpandedState` method is compared to `default` will always evaluate to `false`. This is because the method return value does not have any overlap with `default`. Hence the check is unnecessary. This seems to be a leftover from angular@f9bd5d4.
devversion
force-pushed
the
refactor/expansion-avoid-unnecessary-spacing-check
branch
from
02206cf to
b311f93
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The where expanded equals to
false, and where the return value ofthe
_getExpandedStatemethod is compared todefaultwill alwaysevaluate to
false. This is because the method return value does nothave any overlap with
default. It only returnsexpandedorcollapsed.This seems to be a leftover from f9bd5d4.