fix(chips): unable to set custom tabindex on chip #17699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Nov 14, 2019
mmalerba
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
chip-tabindex
branch
2 times, most recently
from
06dbbe0 to
e80550f
Compare
crisbeto
force-pushed
the
chip-tabindex
branch
from
e80550f to
3556546
Compare
|
@crisbeto this PR has some weirdness in its presubmit; it wasn't clear if it was failing or an unrelated flake. I can re-run if you rebase |
I noticed this as I was going to recommend to someone on GitHub to set a tabindex on a `mat-chip`. As things are setup right now, the `mat-chip` will override whatever `tabindex` is set on it. Note that this isn't an issue on the MDC chip. These changes fix the current `mat-chip` and add tests to the MDC based one on so it doesn't regress.
crisbeto
force-pushed
the
chip-tabindex
branch
from
3556546 to
ab40dd8
Compare
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
I noticed this as I was going to recommend to someone on GitHub to set a tabindex on a `mat-chip`. As things are setup right now, the `mat-chip` will override whatever `tabindex` is set on it. Note that this isn't an issue on the MDC chip. These changes fix the current `mat-chip` and add tests to the MDC based one on so it doesn't regress.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this as I was going to recommend to someone on GitHub to set a tabindex on a
mat-chip. As things are set up right now, themat-chipwill override whatevertabindexis set on it. Note that this isn't an issue on the MDC chip. These changes fix the currentmat-chipand add tests to the MDC based one on so it doesn't regress.