fix(portal): content not rendered inside outlet when view container is provided #17731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s provided Fixes the contents of the portal not being rendered inside of the `CdkPortalOutlet` if an alternate `ViewContainerRef` is provided. We have some logic that moves the content into the outlet for `DomPortalOutlet` already, but we probably missed adding it to the directive since it isn't being used in as many places. Fixes angular#17650.
crisbeto
added
P2
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 26, 2019
Currently we only use the specified `ViewContainerRef` to attach the dialog container, but not the content itself. We couldn't fix this until now due to the bug that was fixed by angular#17731.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the contents of the portal not being rendered inside of the
CdkPortalOutletif an alternateViewContainerRefis provided. We have some logic that moves the content into the outlet forDomPortalOutletalready, but we probably missed adding it to the directive since it isn't being used in as many places.Fixes #17650.