fix(schematics): do not depend on external dependency for colors #17788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we assume that `chalk` always is installed. This has worked without any issues for a long time because most CLI projects had chalk installed. This could potentially change in the projects, or the verison of chalk could accidentally be older/more recent than what our schematics expect. We just remove colors and depend on the devkit logger for colors based on specific logging levels.
googlebot
added
the
cla: yes
devversion
added
the
P1
|
FWIW: I do not like how we need to pass the logger around.. Also I don't like the type of the logger. |
devversion
added
pr: merge safe
target: patch
jelbourn
approved these changes
Nov 22, 2019
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we assume that
chalkalways is installed. This has workedwithout any issues for a long time because most CLI projects had chalk
installed. This could potentially change in the projects, or the verison of
chalk could accidentally be older/more recent than what our schematics
expect. We just remove colors and depend on the devkit logger for colors
based on specific logging levels.