Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): don't handle selection keys while using typeahead in selection list #17826

Merged
merged 1 commit into from
Dec 3, 2019
Merged

fix(list): don't handle selection keys while using typeahead in selection list #17826

merged 1 commit into from
Dec 3, 2019

Conversation

crisbeto
Copy link
Member

Along the same lines as #17785. Doesn't handle space key presses while the user is using the typeahead so that we don't interrupt their typing.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 27, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 27, 2019
jelbourn
jelbourn approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 27, 2019
@ngbot

This comment has been minimized.

Sign in to view
@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Nov 27, 2019
devversion
devversion approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lint seems to be failing

@crisbeto
fix(list): don't handle selection keys while using typeahead in selec…
eb32adf 
…tion list

Along the same lines as angular#17785. Doesn't handle space key presses while the user is using the typeahead so that we don't interrupt their typing.
@crisbeto crisbeto force-pushed the selection-list-typeahead-selection branch from 528068d to eb32adf Compare November 27, 2019 18:51
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 27, 2019
@jelbourn jelbourn merged commit ad42a1b into angular:master Dec 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot