Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: google-maps and youtube-player package missing tslib dependency #17939

Merged
merged 2 commits into from
Dec 11, 2019
Merged

fix: google-maps and youtube-player package missing tslib dependency #17939

merged 2 commits into from
Dec 11, 2019

Conversation

devversion
Copy link
Member

Note: Not sure if we want the second commit to be a fix. Technically it could break people if tslib is not installed. Though that is probably very rare.

@devversion
build: use placeholder for tslib version
ad4612f
@devversion
fix: google-maps and youtube-player package missing tslib dependency
215eeac 
The google-maps and youtube-player package currently do not have
`tslib` listed as dependency while TypeScript helper's are enabled
and used in these packages.
@devversion devversion added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 11, 2019
@devversion devversion added this to the 9.0.0 milestone Dec 11, 2019
@devversion devversion requested review from jelbourn, mmalerba and a team as code owners December 11, 2019 20:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2019
jelbourn
jelbourn approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 11, 2019
@mmalerba mmalerba merged commit 2a2d837 into angular:master Dec 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @googlebot @josephperrott @mmalerba