-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(drag-drop): add injection token for configuring the input defaults #17970
Merged
+239
−43
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
import {InjectionToken} from '@angular/core'; | ||
import {DragRefConfig, Point, DragRef} from '../drag-ref'; | ||
|
||
/** Possible values that can be used to configure the drag start delay. */ | ||
export type DragStartDelay = number | {touch: number, mouse: number}; | ||
|
||
/** Possible axis along which dragging can be locked. */ | ||
export type DragAxis = 'x' | 'y'; | ||
|
||
/** Function that can be used to constrain the position of a dragged element. */ | ||
export type DragConstrainPosition = (point: Point, dragRef: DragRef) => Point; | ||
|
||
/** Possible orientations for a drop list. */ | ||
export type DropListOrientation = 'horizontal' | 'vertical'; | ||
|
||
/** | ||
* Injection token that can be used to configure the | ||
* behavior of the drag&drop-related components. | ||
*/ | ||
export const CDK_DRAG_CONFIG = new InjectionToken<DragDropConfig>('CDK_DRAG_CONFIG'); | ||
|
||
/** | ||
* Object that can be used to configure the drag | ||
* items and drop lists within a module or a component. | ||
*/ | ||
export interface DragDropConfig extends Partial<DragRefConfig> { | ||
lockAxis?: DragAxis; | ||
dragStartDelay?: DragStartDelay; | ||
constrainPosition?: DragConstrainPosition; | ||
previewClass?: string | string[]; | ||
boundaryElement?: string; | ||
rootElementSelector?: string; | ||
draggingDisabled?: boolean; | ||
sortingDisabled?: boolean; | ||
listAutoScrollDisabled?: boolean; | ||
listOrientation?: DropListOrientation; | ||
} | ||
|
||
/** | ||
* @deprecated No longer being used. To be removed. | ||
* @breaking-change 10.0.0 | ||
* @docs-private | ||
*/ | ||
export function CDK_DRAG_CONFIG_FACTORY(): DragDropConfig { | ||
return {dragStartThreshold: 5, pointerDirectionChangeThreshold: 5}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CDK_DRAG_DEFAULT_OPTIONS
for consistency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change since
CDK_DRAG_CONFIG
is already in master.