fix(mdc-chips): Set aria-required on input instead of grid #18049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
vanessanschmitt
force-pushed
the
aria-required
branch
2 times, most recently
from
a59e706 to
d05d64d
Compare
The aria-required attribute is not allowed on elements with role=grid, which causes axe to report an error. If the grid is required, set aria-required on the matChipInputFor input element instead.
vanessanschmitt
force-pushed
the
aria-required
branch
from
d05d64d to
9b8e3bf
Compare
crisbeto
added
Accessibility
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 3, 2020
Sets an `aria-required` on the input that's associated with a chip list. Matches something similar we did for the MDC-based chips in angular#18049 since the MDC chip listbox setup is similar to our current chips setup.
|
In the future, please use |
jelbourn
pushed a commit
that referenced
this pull request
Jan 22, 2020
Sets an `aria-required` on the input that's associated with a chip list. Matches something similar we did for the MDC-based chips in #18049 since the MDC chip listbox setup is similar to our current chips setup.
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…8049) The aria-required attribute is not allowed on elements with role=grid, which causes axe to report an error. If the grid is required, set aria-required on the matChipInputFor input element instead.
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
Sets an `aria-required` on the input that's associated with a chip list. Matches something similar we did for the MDC-based chips in angular#18049 since the MDC chip listbox setup is similar to our current chips setup.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aria-required attribute is not allowed on elements with role=grid, which causes axe
to report an error. If the grid is required, set aria-required on the matChipInputFor
input element instead.
Related to #17397
This commit also contains 2 unrelated minor fixes: 1) remove an unneeded aria-orientation attribute on a demo mat-chip-set that was erroneously copy-pasted from the mat-chip-listbox demo, and 2) change a word in one test name.