fix(scrolling): update virtual scroll viewport size on resize

[crisbeto]

We currently cache the size of the virtual scroll viewport, but it may become inaccurate if it's a percentage of the page viewport and the page is resized. These changes add an extra call that'll update the virtual scroll viewport on resize.

Fixes #16802.

[mmalerba]

I would just mark this @breaking-change, not @deprecated since the change is making it required rather than removing it

[crisbeto]

I’ve been marking these as deprecated in other places, because it’s something standard that’ll show up in people’s tooling, whereas breaking-change is something we made up.

[mmalerba]

I see, I'm not sure if this will show up the way we want though, it will probably show viewportRuler as a deprecated param. What might work better is TS's method overloading. We can mark the old signature deprecated and the new one not deprecated.

Obviously we already have this same pattern all over the code base, but it might be nice to start doing it the way I suggested going forward, I'll leave it up to you

[crisbeto]

Good point that we should be using overloads instead, but I realized that Ivy won't generate the correct code if the constructor is overloaded with a different number of parameters. I've submitted a PR to fix the compiler here angular/angular#34590 so until that gets released I'll keep it as is.

[mmalerba]

Apply merge-ready once the comment is addressed

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}