fix(material): ng-add should always install matching CDK version #18076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ng-add for Angular Material determines the version name of the CDK and Angular Material by looking for `@angular/cdk/package.json` and `@angular/material/package.json` in the node modules. This is incorrect because other installed packages could rely on older CDK versions being installed. In those cases, we don't want to add that transitively installed CDK version to the `package.json` file. Instead, we always want to add the CDK version that matches Angular Material. We can do this by just relying on the version placeholder we use in other locations too. Also in the issue ticket (angular#18020) it was mentioned that we might want to warn if a lower CDK version is transitively installed. This seems unnecessary since we explicitly add a project-scoped dependency on the CDK and transitive CDK dependencies are nothing we should bother about. In general, if someone runs `ng add @angular/material` it's _only_ right to always install a working/matching version of the CDK. Fixes angular#18020
devversion
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…ular#18076) Currently ng-add for Angular Material determines the version name of the CDK and Angular Material by looking for `@angular/cdk/package.json` and `@angular/material/package.json` in the node modules. This is incorrect because other installed packages could rely on older CDK versions being installed. In those cases, we don't want to add that transitively installed CDK version to the `package.json` file. Instead, we always want to add the CDK version that matches Angular Material. We can do this by just relying on the version placeholder we use in other locations too. Also in the issue ticket (angular#18020) it was mentioned that we might want to warn if a lower CDK version is transitively installed. This seems unnecessary since we explicitly add a project-scoped dependency on the CDK and transitive CDK dependencies are nothing we should bother about. In general, if someone runs `ng add @angular/material` it's _only_ right to always install a working/matching version of the CDK. Fixes angular#18020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ng-add for Angular Material determines the version name
of the CDK and Angular Material by looking for
@angular/cdk/package.jsonand
@angular/material/package.jsonin the node modules.This is incorrect because other installed packages could rely on older
CDK versions being installed. In those cases, we don't want to add that
transitively installed CDK version to the
package.jsonfile. Instead,we always want to add the CDK version that matches Angular Material.
We can do this by just relying on the version placeholder we use in
other locations too.
Also in the issue ticket (#18020) it was mentioned that we might want
to warn if a lower CDK version is transitively installed. This seems unnecessary
since we explicitly add a project-scoped dependency on the CDK and transitive
CDK dependencies are scoped to the packages that require it. Also I think it would be
out of scope for
ng addto handle potential scenarios of non-matching CDK installations.Fixes #18020