build: remove unused gulp test watch code #18077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
We can remove the unused code for `gulp test` and `gulp test:static`. The equivalent actions can be performed with Bazel and with the upcoming script that simplifies the testing workflow, there is no need for keeping this code in the codebase. All the concerns that have been mentioned in the old PR (angular#16904) have been resolved.
devversion
force-pushed
the
build/remove-unused-gulp-test-logic
branch
from
5ef8fc0 to
450da6f
Compare
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
We can remove the unused code for `gulp test` and `gulp test:static`. The equivalent actions can be performed with Bazel and with the upcoming script that simplifies the testing workflow, there is no need for keeping this code in the codebase. All the concerns that have been mentioned in the old PR (angular#16904) have been resolved.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can remove the unused code for
gulp testandgulp test:static.The equivalent actions can be performed with Bazel and with the upcoming
script that simplifies the testing workflow, there is no need for
keeping this code in the codebase. All the concerns that have been
mentioned in the old PR (#16904) have been resolved.