Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental): errors with latest MDC canary version #18173

Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix(material-experimental): errors with latest MDC canary version #18173

merged 1 commit into from
Jan 22, 2020

Conversation

crisbeto
Copy link
Member

A few hours ago MDC switched all their Sass to use the new Sass modules (see material-components/material-components-web@faa9af3). This breaks our MDC components since they've been set up to use global Sass variables. These changes switch all the imports to the .import files which use the old approach for exposing variables.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Jan 14, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2020
@crisbeto
Copy link
Member Author

Hmm, this was passing locally. Looks like I'll have to spend a bit more time on it. Will ping when Circle is passing as well.

devversion
devversion approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once CI is green).

@crisbeto crisbeto force-pushed the mdc-sass-modules-errors branch 3 times, most recently from 3f658a8 to e9b7afd Compare January 14, 2020 20:26
@crisbeto
fix(material-experimental): errors with latest MDC canary version
08c86bd 
A few hours ago MDC switched all their Sass to use the new Sass modules (see material-components/material-components-web@faa9af3). This breaks our MDC components since they've been set up to use global Sass variables. These changes switch all the imports to the `.import` files which use the old approach for exposing variables.
@crisbeto crisbeto force-pushed the mdc-sass-modules-errors branch from e9b7afd to 08c86bd Compare January 14, 2020 20:50
@crisbeto
Copy link
Member Author

crisbeto commented Jan 14, 2020 •
edited
Loading

It should be good to go now. @devversion I don't know whether you want to take one more look at it. I had to switch the Gulp-based tasks to use the Dart version of Sass, because node-sass hasn't implemented Sass modules yet.

@jelbourn
Copy link
Member

Right, I should have given you all a heads up about this (MDC switching to the new Sass module system); we'd been talking about it for a while. The Sass team is working on a project to make dart-sass faster to minimize the perf gap. It looks like libsass (on which node-sass is based) is now unmaintained and won't be matching Sass features going forward.

@crisbeto
Copy link
Member Author

FWIW this shouldn't affect our day-to-day workflow too much since it only applies to the Gulp-based CI tasks.

devversion
devversion approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it shouldn't affect us too much. Still LGTM.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 15, 2020
@jelbourn jelbourn merged commit 1b16701 into angular:master Jan 22, 2020
jelbourn pushed a commit that referenced this pull request Jan 22, 2020
@crisbeto @jelbourn
fix(material-experimental): errors with latest MDC canary version (#1…
5d13491 
…8173)

A few hours ago MDC switched all their Sass to use the new Sass modules (see material-components/material-components-web@faa9af3). This breaks our MDC components since they've been set up to use global Sass variables. These changes switch all the imports to the `.import` files which use the old approach for exposing variables.

(cherry picked from commit 1b16701)
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
fix(material-experimental): errors with latest MDC canary version (an…
36e11f6 
…gular#18173)

A few hours ago MDC switched all their Sass to use the new Sass modules (see material-components/material-components-web@faa9af3). This breaks our MDC components since they've been set up to use global Sass variables. These changes switch all the imports to the `.import` files which use the old approach for exposing variables.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@devversion devversion

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @mmalerba @googlebot