Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/*): Add focus indicators to all MDC except mdc-chips. #18175

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Conversation

zelliott
Copy link
Collaborator

@zelliott zelliott commented Jan 14, 2020

  • Added focus indicators to all MDC components that have demo pages and need focus indicators (except chips).
  • Implementation is essentially identical to that for Angular Material. Uses mat-mdc- prefixes (e.g .mat-mdc-focus-indicator, @include mat-mdc-strong-focus-indicators, etc...).
  • Added unit tests that ensure the class is present.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 14, 2020
@zelliott zelliott marked this pull request as ready for review January 15, 2020 00:23
@zelliott zelliott requested review from andrewseguin and removed request for andrewseguin January 15, 2020 00:23
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd like to have @mmalerba, @crisbeto, and @devversion also take a look since they actually worked on this stuff

@zelliott zelliott requested a review from a team as a code owner January 21, 2020 20:30
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jan 21, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jan 21, 2020
@mmalerba
Copy link
Contributor

LGTM

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 21, 2020
@jelbourn jelbourn merged commit e06d269 into angular:focus-indicator Jan 22, 2020
jelbourn pushed a commit that referenced this pull request Jan 28, 2020
mmalerba pushed a commit that referenced this pull request Feb 4, 2020
mmalerba pushed a commit that referenced this pull request Feb 4, 2020
mmalerba pushed a commit that referenced this pull request Feb 12, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants