Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-input): input should not inherit parent classnames #18180

Merged
merged 1 commit into from
Jan 15, 2020
Merged

fix(material-experimental/mdc-input): input should not inherit parent classnames #18180

merged 1 commit into from
Jan 15, 2020

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 15, 2020
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 15, 2020
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jan 15, 2020
@andrewseguin andrewseguin merged commit 500d235 into angular:master Jan 15, 2020
crisbeto
crisbeto approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devversion
devversion reviewed Jan 15, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewseguin
Copy link
Contributor Author

Unfortunately this conflicts with the autosize, which runs it's algorithm of fitting to content BEFORE the mat-input-element class is added (since it's now a binding and the order has changed)

@andrewseguin andrewseguin mentioned this pull request Jan 16, 2020
Merged
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@andrewseguin @yifange
fix(material-experimental/mdc-input): input should not inherit parent…
7cebdf8 
… classnames (angular#18180)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewseguin @crisbeto @devversion @mmalerba @googlebot