fix(youtube-player): handle API interactions before API has loaded

[crisbeto]

Currently if the user tries to interact with the API before the YouTube API has loaded (e.g. by calling playVideo) their method call will be ignored. These changes add some logic that will store the state and replay it once the player has been initialized.

Fixes #18279.

[mcroker]

@crisbeto - thank-you for jumping in and helping with this issue...
...the PR doesn't quite solve the issue for me - specifically I was calling player.getDuration() on the ready event which is don't think you've addressed

Your PR did however give me insight into what was going on. Is there any reason we wouldn't just move the ready event to be triggered by the playerObs?

    // Set up side effects to bind inputs to the player.
    playerObs.subscribe(player => {
      this._player = player
      this.ready.emit({} as YT.PlayerEvent);
    });

and of course remove the current trigger for ready...

    const events = new Map<keyof YT.Events, EventEmitter<any>>([
      ['onReady', this.notTheCurrentReadyEvent],
...
    ]);

[crisbeto]

I'm not the one that set up the component initially so I don't have all the context, but I think that it's written this way, because we bind to the onReady event from the YouTube API, rather than emit when we think that the player is ready. These two could be emitted at different times (e.g. if we create the player, but have to wait a while for it to become ready).

[mcroker]

From the point of view of a external component, I consider the component to be ready when I can interact with the player... I can see it's coming from the iFrame player, but I'm not entirely sure what the current ready event gives me as I can't yet interact with the player.

Perhaps two events would be the right solution? onIFramePlayerReadyEvent, and onReady?

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}